Skip to content

Conversation

@holgerroth
Copy link
Collaborator

Fixes # .

Description

Increase the link check timeout to avoid CI failures on slow-responding websites.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@holgerroth
Copy link
Collaborator Author

/build

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 23, 2026

Greptile Overview

Greptile Summary

This PR increases the timeout for the lychee link checker in the CI workflow from the default value to 30 seconds to prevent false failures when checking links to slow-responding external websites.

  • Added --timeout=30 parameter to the lychee-action configuration in the markdown links check workflow
  • This change helps avoid CI failures caused by network latency or slow external servers
  • The modification is minimal and maintains all existing functionality

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change adds a single configuration parameter to increase timeout tolerance for link checking, which only affects CI behavior and cannot impact runtime functionality or introduce bugs
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/markdown-links-check.yml Added --timeout=30 parameter to lychee link checker to handle slow-responding websites

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Workflow
    participant LC as Lychee Action
    participant MD as Markdown Files
    participant EXT as External Links

    GH->>LC: Trigger link check on push/PR
    LC->>MD: Scan **/*.md, **/*.html, **/*.rst
    MD-->>LC: Return links to check
    loop For each link
        LC->>EXT: HTTP request to verify link
        alt Response within 30s
            EXT-->>LC: Return status (200, 403, or 429)
            LC->>LC: Mark link as valid
        else Timeout after 30s
            EXT--xLC: No response
            LC->>LC: Mark link as timeout
        end
    end
    LC-->>GH: Report results (fail on timeout/broken links)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@holgerroth holgerroth enabled auto-merge (squash) January 23, 2026 15:20
@holgerroth holgerroth changed the title Increase link check timeout [2.7] Increase link check timeout Jan 23, 2026
@holgerroth holgerroth merged commit 12d5a8e into NVIDIA:2.7 Jan 23, 2026
20 checks passed
@holgerroth holgerroth deleted the link_check_timeout_2.7 branch January 23, 2026 15:36
holgerroth added a commit to holgerroth/NVFlare that referenced this pull request Jan 23, 2026
Fixes # .

### Description

Increase the link check timeout to avoid CI failures on slow-responding
websites.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Quick tests passed locally by running `./runtest.sh`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated.
@holgerroth holgerroth mentioned this pull request Jan 23, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants